Skip to content

fix: ignore popover elements in a11y_consider_explicit_label check #17367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RazinShafayet2007 wants to merge 2 commits into
base: main
Choose a base branch
from
+36 −0
Open

fix: ignore popover elements in a11y_consider_explicit_label check #17367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055e28c
fix: ignore popover elements in a11y_consider_explicit_label check
RazinShafayet2007 Dec 16, 2025
df72d30
chore: add changeset
RazinShafayet2007 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-phones-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

Fix false negative for a11y_consider_explicit_label with popover elements
6 changes: 6 additions & 0 deletions packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,12 @@ function has_content(element) {
}

if (node.type === 'RegularElement' || node.type === 'SvelteElement') {
// FIX START: Ignore elements with the popover attribute
if (node.attributes.some((a) => a.type === 'Attribute' && a.name === 'popover')) {
continue;
}
// FIX END

if (
node.name === 'img' &&
node.attributes.some((node) => node.type === 'Attribute' && node.name === 'alt')
Expand Down
17 changes: 17 additions & 0 deletions packages/svelte/tests/validator/samples/a11y-popover-label/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<button interestfor="verified-hint">
<svg width="16" height="16" viewBox="0 0 24 24"><path d="M23,12L20.56,9.22L20.9,5.54L17.29,4.72L15.4,1.54L12,3L8.6,1.54L6.71,4.72L3.1,5.53L3.44,9.21L1,12L3.44,14.78L3.1,18.47L6.71,19.29L8.6,22.47L12,21L15.4,22.46L17.29,19.28L20.9,18.46L20.56,14.78L23,12M10,17L6,13L7.41,11.59L10,14.17L16.59,7.58L18,9L10,17Z" /></svg>
<div id="verified-hint" popover="hint">
Verified
</div>
</button>

<style>
button {
margin: 1rem;
}

[popover] {
position-area: block-start center;
margin: 0;
}
</style>
8 changes: 8 additions & 0 deletions packages/svelte/tests/validator/samples/a11y-popover-label/warnings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[
{
"code": "a11y_consider_explicit_label",
"message": "Buttons and links should either contain text or have an `aria-label`, `aria-labelledby` or `title` attribute",
"start": { "line": 1, "column": 0 },
"end": { "line": 6, "column": 11 }
}
]
Loading