fix: apply static value attribute as textarea content on CSR - #18627
Open
sankalpsthakur wants to merge 1 commit into
Open
fix: apply static value attribute as textarea content on CSR#18627sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
Browsers ignore the value HTML attribute on <textarea>, so static
value="..." was a no-op on client-side rendering while SSR and dynamic
value={...} already worked. Emit the static value as child text in the
template (matching SSR) so value and defaultValue are set.
Fixes sveltejs#18574
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/44399162f42761a8b0805751e66820a229dba6fbOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 4439916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lintFixes #18574
Problem
Static
valueon<textarea>was inconsistent between CSR and SSR:<textarea value="hi">hi<textarea value={'hi'}>hihiBrowsers ignore the
valueHTML attribute on<textarea>(only child text content or the JSvalueproperty matter). The client compiler was baking static values into the template asvalue="hi", which is a no-op.Fix
When compiling a static text
valueattribute on<textarea>, emit the value as template child text (with the same leading-newline and HTML-escape handling as the SSR path) instead of as an attribute. Dynamicvalue={...}already uses$.set_valueand is unchanged.Compiled client output goes from:
to:
defaultValueSSR remains out of scope here (tracked separately, e.g. #18446 / related PRs).Tests
runtime-runes/samples/textarea-static-value— static attr, static expression, dynamic, children, leading newline, escaped content; assertsvalueanddefaultValueserver-side-rendering/samples/textarea-static-value— expected HTML for static/dynamic/escaped casesLocal:
FILTER=/textarea/ pnpm testandFILTER=textarea-static-value pnpm testpass.AI disclosure: This contribution was prepared with assistance from an LLM-based coding agent. The change was reviewed and verified locally (repro, targeted tests) before opening the PR.