fix: stop currentTime binding updates during outros - #18642
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
Draft
fix: stop currentTime binding updates during outros#18642svelte-triage-bot[bot] wants to merge 1 commit into
svelte-triage-bot[bot] wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/b2a6c0c9f93df27bee38ac31b41bb381a5c6e822Open in |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15053.
The
currentTimebinding's RAF/event callback continued writing after its owning branch effect became inert during an outro. If the binding targeted a property on the condition value, that value could already benull, producingCannot set properties of null.This captures the binding's owning effect and skips media-to-state writes while that effect is inert. A reduced
transition-media-binding-outroruntime-runes sample reproduces the failure by dispatchingtimeupdatewhile the audio element is outroing.Verification:
Cannot set properties of null (setting 'currentTime')and passes after it.pnpm test runtime-runes: 2660 passed, 47 skipped.Self-review found and fixed an effect typing issue; no remaining blocking or worth-fixing findings.