Skip to content

fix: stop currentTime binding updates during outros - #18642

Draft
svelte-triage-bot[bot] wants to merge 1 commit into
mainfrom
svelte0/svelte-15053-fix-stop-currenttime-binding-updates-during-outros
Draft

fix: stop currentTime binding updates during outros#18642
svelte-triage-bot[bot] wants to merge 1 commit into
mainfrom
svelte0/svelte-15053-fix-stop-currenttime-binding-updates-during-outros

Conversation

@svelte-triage-bot

Copy link
Copy Markdown
Contributor

Fixes #15053.

The currentTime binding's RAF/event callback continued writing after its owning branch effect became inert during an outro. If the binding targeted a property on the condition value, that value could already be null, producing Cannot set properties of null.

This captures the binding's owning effect and skips media-to-state writes while that effect is inert. A reduced transition-media-binding-outro runtime-runes sample reproduces the failure by dispatching timeupdate while the audio element is outroing.

Verification:

  • Reduced test failed before the patch with Cannot set properties of null (setting 'currentTime') and passes after it.
  • pnpm test runtime-runes: 2660 passed, 47 skipped.

Self-review found and fixed an effect typing issue; no remaining blocking or worth-fixing findings.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of svelte from b2a6c0c:

pnpm add https://pkg.svelte.dev/svelte/c/b2a6c0c9f93df27bee38ac31b41bb381a5c6e822

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/svelte/pr/18642

@changeset-bot

changeset-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b2a6c0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set properties of null (setting 'currentTime'), when transition

0 participants