fix: measure nested transitions before applying their starting styles - #18647
Open
61021 wants to merge 1 commit into
Open
fix: measure nested transitions before applying their starting styles#1864761021 wants to merge 1 commit into
61021 wants to merge 1 commit into
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/8423f6c2a509bfb4f5ff7504a7398a5968724cbbOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 8423f6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18421 (regression from #16035, which re-broke the #4784 scenario).
Since #16035 the dummy delay animation runs with
fill: 'forwards', so an intro'st = 0styles (forslide,height: 0) apply the moment the transition is created and stay applied until the real animation starts a frame later. Transition functions of other elements in the same batch run after that and measure a collapsed DOM. With nested intros (the TreeView from the issue), intro effects run deepest-first, so every ancestor'sslidecaptures a height where its children are pinned at 0. On the issue's REPL every<ul>animates0px -> 36px(the height of a single row) and then jumps to its real size when the animation finishes, which is the "children pop out" behavior from #4784.The fix waits one microtask before applying the initial styles and creating the dummy, the same way deferred transitions (
crossfade) already work inanimate(). Everything in the batch measures the DOM first; the microtask still runs before the next paint, so elements never render unstyled and the #14732 behavior is preserved. Verified in a real browser that a delayed intro (delay: 300) stays held atheight: 0for the whole delay, including the first painted frame.Most of the diff is the existing dummy/onfinish block moving into
queue_micro_task; hiding whitespace shows the actual change.Test plan
runtime-browsertesttransition-nested-measure: three nestedslide|globalintros, asserting the outermost animation's final keyframe equals the natural height (100px). I ran the same assertion against a real Chromium on both builds:0pxon main,100pxwith the fix. The unit-test mock can't catch this (it applies keyframes synchronously and jsdom has no layout), which is presumably also why fix: transitions might render animated elements without animation styles applied for the duration of some rendering frames when they start #16035 landed without a test.pnpm test runtime-runes runtime-legacy: 5972 passed,pnpm checkandpnpm lintclean