fix: prevent stale reads when tracking new dependencies during pending async work - #18674
Open
jkbz64 wants to merge 3 commits into
Open
fix: prevent stale reads when tracking new dependencies during pending async work#18674jkbz64 wants to merge 3 commits into
jkbz64 wants to merge 3 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/0ec0b458fc80badcc2cfd78495abc23bfe9dc20dOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 0ec0b45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sveltejs/kit#16207
I've found a minimal reproduction from the issue above and tried to slop it a bit, feel free to re-use the repro and fix it properly if it's bad.
Merges a newer batch with an earlier pending batch when it starts reading state changed by that batch, preventing stale values from reaching newly dependent UI.
The change also modified the behavior of some tests but the comments there said "if this is not here then this would also be ok" so I guess that passes? I'm not really confident about that change but it does not break other tests and seems to fix the issue.
Assisted-by: Codex