fix: accept onfocusin/onfocusout in a11y_mouse_events_have_key_events - #18689
Open
giaBaoJS wants to merge 1 commit into
Open
fix: accept onfocusin/onfocusout in a11y_mouse_events_have_key_events#18689giaBaoJS wants to merge 1 commit into
onfocusin/onfocusout in a11y_mouse_events_have_key_events#18689giaBaoJS wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/d27f7034776940efdbb4ed8599931ac3812abe61Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d27f703 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8089
a11y_mouse_events_have_key_eventscurrently accepts onlyfocusas a partner formouseoverand onlybluras a partner formouseout. Butfocusandblurdo not bubble, so an element that is not itself focusable — the common case for a hover-triggered tooltip wrapper, a<div>, a heading — can never receive them. The bubbling equivalents arefocusinandfocusout.The result is that correct markup gets warned about, and the only way to silence the warning is to attach a handler that can never fire:
This widens the check to treat
focusin/focusoutas satisfying the rule, which is what @f-elix suggested on the issue. No new API and no new warnings — it strictly removes false positives; markup with neitherfocusnorfocusinstill warns.Changes
a11y/index.js: acceptfocusinalongsidefocus, andfocusoutalongsideblurmessages/compile-warnings/a11y.md: document the accepted alternatives (+ regenerateddocumentation/docs/98-reference/.generated/compile-warnings.mdviapnpm generate)a11y-mouse-events-have-key-eventsvalidator sampleTest plan
The new fixture cases fail without the source change (the compiler emits two unexpected
a11y_mouse_events_have_key_eventswarnings on lines 21 and 23), and the two pre-existing cases —<div onmouseover>and<div onmouseout>with no focus partner at all — still warn, so the rule is not simply disabled.