Repository navigation
fix: batch views of reactions #19030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dummdidumm
wants to merge
93
commits into
main
Choose a base branch
from
batch-views
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17,937
−1,274
Open
Changes from 51 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
d28ea11
wip
dummdidumm 4a22781
speed up / reduce code size a bit / fix error bug
dummdidumm 0a1b1c2
tweak implementation, reduce concepts a bit
dummdidumm ab9863c
fix
dummdidumm a996f40
simplify/fix
dummdidumm 508b190
merge dirty_reactions into unprocessed, comments
dummdidumm 6d3317f
simplify/comments
dummdidumm 06f7ec0
bring over tests that pass unchanged
dummdidumm fd71c0c
tmp: commit md file
dummdidumm f9f01bd
turn references into crosslinks
Rich-Harris 39aa80d
define folding
Rich-Harris b92bc88
note possible future simplification (simon, feel free to revert if th…
Rich-Harris 7e395a1
commit some adjusted tests (some names outdated, some superfluous bec…
dummdidumm 52909d7
fix tricky "assigned deriveds" cases
dummdidumm f1e0759
fix unskip logic, avoid needless reruns when derived's earlier value …
dummdidumm aeefd9c
each bug fix
dummdidumm 847f648
note found bug, don't fix now but add skipped tests
dummdidumm 268b74d
bring over two more passing tests from pt-1 branch
dummdidumm abd8bb9
(partially) fix behavior when pending snippet exists
dummdidumm f0dee8a
wait on the batch at the run/flatten creation time to resume with the…
dummdidumm 75b6957
forgot this test
dummdidumm 4b481d3
fix + simplify derived assignments, move cache deriveds out of batch_…
dummdidumm 8eaa2d7
tidy up
dummdidumm 32c62ea
fix/simplify/consolidate error handling
dummdidumm e4927f2
cleanup
dummdidumm f7a5597
code-golf
dummdidumm 82b4298
tweak
dummdidumm b202c4c
prune effect edges
dummdidumm d3d995a
more code golf
dummdidumm b3d3a0a
Merge branch 'main' into batch-views
dummdidumm 9561f67
tweak/fix pending boundary logic, still not super happy with the outcome
dummdidumm edc48da
remove obsolete test
dummdidumm 2c94751
making tracing view-aware
dummdidumm 272e649
use deps here
dummdidumm 7d1e346
fix effect resume bug
dummdidumm ecd3fa9
merge main
Rich-Harris 7b9b639
merge main
Rich-Harris a62c812
Apply suggestions from code review
Rich-Harris 0586820
chore: DRY out dirty reaction code (#19074)
Rich-Harris 4e5654c
chore: skip eager effects during traversal (#19079)
Rich-Harris 611f512
add test that fails on `batch-views-simplify-capture`
Rich-Harris b2fc8db
fix test
Rich-Harris 33718ef
Merge branch 'main' into batch-views
Rich-Harris b96b9ea
merge main
Rich-Harris 729c983
Update packages/svelte/src/internal/client/reactivity/batch.js
Rich-Harris f47ce78
Update packages/svelte/src/internal/client/runtime.js
Rich-Harris 9e9c54c
Update packages/svelte/src/internal/client/reactivity/batch.js
Rich-Harris 96f1e7c
tweak
Rich-Harris 7e127b3
tweak
Rich-Harris dc26210
fix: don't run `$inspect` and `$state.eager` with the values of a for…
Rich-Harris 6cd2bc5
chore: DRY out update_derived callsites (#19110)
Rich-Harris 14c896a
merge main
Rich-Harris 42f278f
fix: revert state changes in effect teardowns based on the currently …
Rich-Harris 4ef7a45
chore: bypass internal_set when handling async results (#19111)
Rich-Harris e3e2cd3
fix: don't re-run `$inspect` effects if values are unchanged (#19077)
Rich-Harris 42bc77d
chore: dedupe source.v etc assignments (#19115)
Rich-Harris 58ebd5b
Update packages/svelte/src/internal/client/runtime.js
Rich-Harris 867262b
prettier
Rich-Harris 387cda6
perf: don't re-validate branches that were just created offscreen (#1…
Rich-Harris 2e54086
perf: don't revalidate a batch that was the most recent to be process…
Rich-Harris d239ba4
fix: don't touch the active batch's records when running in the real …
Rich-Harris 25bce04
fix: don't throw when committing a fork whose changes were all supers…
Rich-Harris c678d4e
fix: reset view if fork callback throws (#19120)
Rich-Harris 0f8e6cd
chore: document that the active view sees writes made while it is act…
Rich-Harris ece1e40
docs: fix various errors in `batch-views.md` (#19127)
Rich-Harris bc53186
fix: don't re-run effects that already saw a write made while a batch…
Rich-Harris 23b3898
fix: rebase later batches whose writes are all among those of a commi…
Rich-Harris 931b389
Merge branch 'main' into batch-views
dummdidumm fb0058a
Merge branch 'main' into batch-views
dummdidumm f0486b8
fix: don't let teardowns see a derived's computed value from before a…
Rich-Harris 6ae1805
chore: make it explicit that update_derived is called with sources (#…
Rich-Harris 9dd642c
chore: reduce number of `current_batch` assignments, remove `previous…
Rich-Harris 40e9ac8
chore: document that a batch's first-value writes have no previous en…
Rich-Harris cd5baf5
chore: defer all effects while another batch commits, regardless of a…
Rich-Harris a657999
fix: correctly preserve/discard each item effects in forks (#19167)
Rich-Harris a09517e
fix: in `batch.current`, always specify whether a value was assigned …
Rich-Harris 26de2ef
chore: make `e` and `assigned` required properties of `BatchValue` (#…
Rich-Harris 4300a59
fix: keep assignments to deriveds whose derived dependencies are eval…
Rich-Harris 50d6f08
chore: revalidate without recursion (#19060)
Rich-Harris 3653d77
chore: simplify `update_dependencies` (#19182)
Rich-Harris a391635
chore: simplify `update_record` (#19185)
Rich-Harris 33d2b8f
chore: use `should_record` boolean inside `update_record` (#19189)
Rich-Harris c8513b9
fix: don't commit branches eagerly during flush (#19221)
dummdidumm 51718d6
fix: move batches that committed with pending work to the front (#19235)
Rich-Harris 784fcd4
fix: don't let forks take over async results (#19234)
dummdidumm 4f34b11
fix: better abort signal handling (#19168)
Rich-Harris 54c3364
fix: properly support `{#await }` blocks in async mode (#19236)
dummdidumm c829f8a
Merge branch 'main' into batch-views
dummdidumm b8e262c
fix: don't override newer values on fork commit (#19244)
dummdidumm e7ea0c4
fix: create effects in `flatten` whenever values are ready (#19242)
Rich-Harris 0a3f505
fix: don't bail out of internal_set if value matches real world but d…
Rich-Harris 4a669eb
obsolete comment
Rich-Harris ef13a2b
Merge branch 'main' into batch-views
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'svelte': patch | ||
| --- | ||
|
|
||
| fix: keep values computed in a batch's view of the world local to that batch, and don't needlessly re-run deriveds while several batches are pending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'svelte': patch | ||
| --- | ||
|
|
||
| fix: don't run `$inspect` and `$state.eager` with the values of a fork before it is committed |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.