Repository navigation
chore: better async derived labels - #19068
Open
Rich-Harris wants to merge 1 commit into
Open
Rich-Harris wants to merge 1 commit into
Rich-Harris wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/ee97519870fb5c8bf6ed8876c04c3278e78bb759Open in |
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+523
to
+527
| return `{${fn.toString() | ||
| .replace(/^async \(\) => /, '') | ||
| .replace(/^\(/, '') | ||
| .replace(/\$\.get\((.+?)\)/, (_, name) => name) | ||
| .replace(/\$\.track_reactivity_loss\((.+?)\)\(\)/, (_, name) => name) |
Comment on lines
+523
to
+526
| return `{${fn.toString() | ||
| .replace(/^async \(\) => /, '') | ||
| .replace(/^\(/, '') | ||
| .replace(/\$\.get\((.+?)\)/, (_, name) => name) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small quality of life change with no user-observable effects. Basically, it means that await expressions in the template are labelled with the code that was actually written (or something close to it) — if you have something like this...
...then the signal is labeled as
{await foo()}instead ofasync () => (await $.track_reactivity_loss($.get(foo)))().