Convert numeric character references representing < and & into < and &#3
Open
brettz9 wants to merge 2 commits intosvg:masterfrom
Open
Convert numeric character references representing < and & into < and &#3brettz9 wants to merge 2 commits intosvg:masterfrom
< and & into < and &#3brettz9 wants to merge 2 commits intosvg:masterfrom
Conversation
…to `<` and `&`, as otherwise may break well-formedness; fixes svg#1
brettz9
added a commit
to brettz9/svgo
that referenced
this pull request
Dec 23, 2021
fix: avoid escaping numeric entities or predefined entities lt and amp Also allows .idea in .gitignore
Author
|
@TrySound : Could you take a look? |
Author
|
Could I get a review or get an ETA? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: convert numeric character references representing
<and&into<and&, as otherwise may break well-formedness; fixes #1 ; closes #2Also ensures a more readable form is returned than I had proposed for #2.
In the first commit, the
attributeandattributesvalues differ here (they remain escaped) than the equivalent for text (which returns<to<and&to&), but this appears to be a preexisting issue.However, in order to fix that issue, I've added a second commit to address the attribute values not being unescaped when accessed, e.g., by the attribute
value.