Fix image download error handling in "gulpfile.js" and "downloadSingleImage.js" from issue #1283 #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `gulpfile.js` to handle image download errors gracefully by logging warnings instead of throwing errors. - Enhanced `downloadSingleImage` function to implement retry logic for failed downloads, allowing for up to 3 attempts. - Improved error logging and cleanup for partial downloads, ensuring smoother build processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
gulp.task("swag-img:download")ingulpfile.jsto handle image download errors gracefully by logging warnings instead of throwing errors.downloadSingleImagefunction to implement retry logic for failed downloads, allowing for up to 3 attempts.Reference
Check issue #1283 for reference.
Note: I did this under Hacktoberfest.
Additional Note
P.S. I am using a VS Code extension called Prettier, which formats the code automatically. This is why there are so many changes in the formatting.