Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): install nodejs version according to nvmrc #580

Merged
merged 6 commits into from
May 2, 2020
Merged

feat(ci): install nodejs version according to nvmrc #580

merged 6 commits into from
May 2, 2020

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented May 2, 2020 •
edited
Loading

@aslafy-z
Copy link
Collaborator Author

aslafy-z commented May 2, 2020

@vikaspotluri123 can you have a look? I removed the names so we can clearly see what's going on in these steps. No choice but duplicating the node setup code sadly (https://github.community/t5/GitHub-Actions/Support-for-YAML-anchors/m-p/30336).

@aslafy-z aslafy-z merged commit fab0a4e into master May 2, 2020
@aslafy-z aslafy-z deleted the aslafy-z-actions-use-nvm branch May 2, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikaspotluri123 vikaspotluri123 vikaspotluri123 approved these changes

@swapagarwal swapagarwal Awaiting requested review from swapagarwal swapagarwal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslafy-z @vikaspotluri123