Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add JSON schema validation #797

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

feat: add JSON schema validation #797

wants to merge 39 commits into from

Conversation

ritesh-pandey
Copy link
Contributor

  • I've checked that this isn't a new swag opportunity proposal.
  • I've checked that this isn't a duplicate pull request.

Added AJV-based JSON schema validation.

aslafy-z
aslafy-z reviewed Nov 6, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
aslafy-z
aslafy-z reviewed Nov 6, 2020
View reviewed changes
schema.json Show resolved Hide resolved
ritesh-pandey and others added 22 commits November 7, 2020 22:16
@ritesh-pandey
Moved ajv from dependency to devDependency
d50f4e6
@ritesh-pandey
Added Chai plug-in for running tests
23f6888
@ritesh-pandey
Removed chai plug-in for schema validation
2b4426c
@ARKEOLOGIST
feat: expose dataset on website (swapagarwal#795)
7ae574e 
closes swapagarwal#534
@aslafy-z
fix(swag): update broken image links (swapagarwal#835)
12f69af
@dependabot
chore(deps): bump path-parse from 1.0.6 to 1.0.7 (swapagarwal#838)
4a247fe 
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Nikhil27b
fix(swag): set Img Bot opportunity as expired (swapagarwal#837)
5d2a40a 
Added the expired tag in Img bot they are DISCONTINUED
@aslafy-z
fix(swag): update openebs image (swapagarwal#844)
e333076
@aslafy-z
feat: replace renovate with dependabot (swapagarwal#841)
8c3556f
@dependabot
chore(deps): bump actions/setup-node from 1 to 2.4.0 (swapagarwal#845)
7651c9c 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 1 to 2.4.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v1...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/cache from 1 to 2.1.6 (swapagarwal#846)
9f7f3ae 
Bumps [actions/cache](https://github.com/actions/cache) from 1 to 2.1.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v1...v2.1.6)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump postcss from 8.1.6 to 8.3.6 (swapagarwal#847)
4db726e 
Bumps [postcss](https://github.com/postcss/postcss) from 8.1.6 to 8.3.6.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.1.6...8.3.6)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump browserslist from 4.14.5 to 4.16.8 (swapagarwal#848)
f48d027 
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.5 to 4.16.8.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.14.5...4.16.8)

---
updated-dependencies:
- dependency-name: browserslist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump hosted-git-info from 2.7.1 to 2.8.9 (swapagarwal#820)
67862a8 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.7.1 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.7.1...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump lodash from 4.17.19 to 4.17.21 (swapagarwal#819)
1e1e743 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump ini from 1.3.5 to 1.3.8 (swapagarwal#849)
7f0773e 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

---
updated-dependencies:
- dependency-name: ini
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump y18n from 3.2.1 to 3.2.2 (swapagarwal#814)
6308d9f 
Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump pug-code-gen from 2.0.1 to 2.0.3 (swapagarwal#813)
e8e7948 
Bumps [pug-code-gen](https://github.com/pugjs/pug) from 2.0.1 to 2.0.3.
- [Release notes](https://github.com/pugjs/pug/releases)
- [Commits](https://github.com/pugjs/pug/compare/[email protected]@2.0.3)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump chai from 4.2.0 to 4.3.4 (swapagarwal#851)
eef510e 
Bumps [chai](https://github.com/chaijs/chai) from 4.2.0 to 4.3.4.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@4.2.0...v4.3.4)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump mocha from 8.2.1 to 9.1.0 (swapagarwal#850)
c860f07 
Bumps [mocha](https://github.com/mochajs/mocha) from 8.2.1 to 9.1.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.2.1...v9.1.0)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump sharp from 0.26.2 to 0.29.0 (swapagarwal#852)
e5855b0 
Bumps [sharp](https://github.com/lovell/sharp) from 0.26.2 to 0.29.0.
- [Release notes](https://github.com/lovell/sharp/releases)
- [Changelog](https://github.com/lovell/sharp/blob/master/docs/changelog.md)
- [Commits](lovell/sharp@v0.26.2...v0.29.0)

---
updated-dependencies:
- dependency-name: sharp
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/core from 7.12.3 to 7.15.0 (swapagarwal#853
dbac040 
)

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.3 to 7.15.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.15.0/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@aslafy-z aslafy-z changed the title Added JSON schema validation feat: add JSON schema validation Aug 24, 2021
aslafy-z
aslafy-z reviewed Aug 24, 2021
View reviewed changes
schema.json Outdated Show resolved Hide resolved
@aslafy-z
Copy link
Collaborator

@ritesh-pandey Can you please rebase your branch so we can merge your PR?
Thank you for the awesome contribution!

@ritesh-pandey
Copy link
Contributor Author

Rebased the branch. The error message needs improvement. It is not very intuitive at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z approved these changes

@swapagarwal swapagarwal Awaiting requested review from swapagarwal swapagarwal is a code owner

@vikaspotluri123 vikaspotluri123 Awaiting requested review from vikaspotluri123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ritesh-pandey @aslafy-z @vikaspotluri123 @ARKEOLOGIST @Nikhil27b @amhislop