Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Update all occurrences of file_cache to use sha1 instead of md5. There are two files. #3334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MartinYe1234
Copy link
Collaborator

Description

This pull request updates the hashing algorithm used in the file_cache functionality from md5 to sha1 across all occurrences within the documentation. The change aims to enhance security and reduce the likelihood of hash collisions as the volume of cached data increases.

Summary

  • Changed hashing algorithm from md5 to sha1 in the file_cache.mdx documentation to improve security and collision resistance.
  • Added a note explaining the rationale behind the shift from md5 to sha1 for the file_cache functionality, highlighting the benefits of a longer hash in reducing collision probabilities.
  • Ensured that all code snippets within the documentation reflect this change, making the file_cache mechanism more reliable and efficient for users.

Fixes #3333.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@MartinYe1234
Copy link
Collaborator Author

Rollback Files For Sweep

  • Rollback changes to docs/pages/blogs/file-cache.mdx
  • Rollback changes to docs/public/file_cache.py

This is an automated message generated by Sweep AI.

@MartinYe1234
Copy link
Collaborator Author

Apply Sweep Rules to your PR?

  • Apply: We should use loguru for error logging. If the log is inside an exception, use logger.exception to add tracebacks, where logger is imported from loguru. Use f-strings for string formatting in logger calls (e.g. logger.info(f'Hello {name}') instead of logger.info('Hello {name}', name=name)).
  • Apply: There should be no debug log or print statements in production code.
  • Apply: All functions should have parameters and output annotated with type hints. Use list, tuple and dict instead of typing.List, typing.Tuple and typing.dict.
  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the same directory. For example, sweepai/api_test.py tests sweepai/api.py. Use unittest and unittest.mock as required.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.
  • Apply: Remove any comments before code that are obvious. For example # this prints hello world; print('hello world').

This is an automated message generated by Sweep AI.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sweep-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 5:55pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Update all occurrences of file_cache to use sha1 instead of md5. There are two files.
2 participants