Skip to content

Commit 22fceb3

Browse files
authored
Prep for 5.0 (#177)
* Prep for 5.0 * fix markdown * update readme
1 parent 22b2d43 commit 22fceb3

File tree

5 files changed

+54
-9
lines changed

5 files changed

+54
-9
lines changed

CONTRIBUTORS.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,25 @@ needs to be listed here.
1212
- Craig Newell <[email protected]>
1313
- Eduardo Perez <[email protected]>
1414
- Florian Reinhart <[email protected]>
15+
- Franz Busch <[email protected]>
1516
- Geoff Verdouw <[email protected]>
1617
- Jeffrey Macko <[email protected]>
1718
1819
- Kyle Browning <[email protected]>
1920
- Laurent Gaches <[email protected]>
2021
- Lukáš Petr <[email protected]>
2122
- Mads Odgaard <[email protected]>
23+
- Mark Woollard <[email protected]>
2224
- Nikola Paunović <[email protected]>
2325
- Roderic Campbell <[email protected]>
2426
- Simon Kempendorf <[email protected]>
27+
- Sven A. Schmidt <[email protected]>
2528
2629
- Tanner Nelson <[email protected]>
30+
- Tim Condon <[email protected]>
2731
- Timothy Ellis <[email protected]>
32+
- Timothy Ellis <[email protected]>
33+
- Vojtech Rylko <[email protected]>
2834
2935
- itcohorts <[email protected]>
3036
- tanner0101 <[email protected]>

README.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,7 @@ To install `APNSwift`, just add the package as a dependency in your [**Package.s
2727

2828
```swift
2929
dependencies: [
30-
.package(url: "https://github.com/swift-server-community/APNSwift.git", from: "4.0.0"),
31-
]
32-
```
33-
If youd like to give our bleeding edge release a try, which is what the Readme is expecting use `5.0.0-beta.N`. If you need the old Readme, see [here](https://github.com/swift-server-community/APNSwift/tree/4.0.0)
34-
35-
```swift
36-
dependencies: [
37-
.package(url: "https://github.com/swift-server-community/APNSwift.git", from: "5.0.0-beta.2"),
30+
.package(url: "https://github.com/swift-server-community/APNSwift.git", from: "5.0.0"),
3831
]
3932
```
4033

@@ -189,3 +182,4 @@ Once inside configure your App Bundle ID and assign your development team. Build
189182

190183
* Pitch discussion: [Swift Server Forums](https://forums.swift.org/t/apple-push-notification-service-implementation-pitch/20193)
191184
* Proposal: [SSWG-0006](https://forums.swift.org/t/feedback-nioapns-nio-based-apple-push-notification-service/24393)
185+
* 5.0 breaking changings: [Swift Server Forums]([Blog post here on breaking changing](https://forums.swift.org/t/apnswift-5-0-0-beta-release/60075/3))

RELEASING.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Updating code/Release workflow
2+
3+
APNSwift follows a standard open source release process
4+
5+
## Issue and Pull Request Management
6+
7+
The primary objective of managing Issues and Pull Requests (PRs) is to enable easy reference to them in the future and to ensure a clear record of when specific issues were addressed in a release.
8+
9+
- **Creating GitHub Issues and Linking PRs:** Every significant task should have an associated GitHub issue, and when a PR resolves an issue, it should be linked using GitHub's "resolves #1234" mechanism or another clear indication of the associated issue.
10+
11+
- **Closing Issues and PRs:** When a PR gets merged, the related issue is automatically closed, and the issue is assigned to the milestone corresponding to the release in which the change will be included.
12+
13+
- **Handling PRs without Associated Issues:** In cases where a pull request is made directly without an associated issue, it should be linked to the relevant milestone for the release. However, it's essential not to assign both an issue and a pull request related to the same task to the same milestone, as this could lead to confusion regarding duplicated issue resolutions.
14+
15+
## Release Process
16+
17+
When preparing for a new release, APNSWift will follow these steps. Let's use version `1.2.3` as an example:
18+
19+
1. Check all outstanding PRs, and if any can be merged for the current release (`1.2.3`), consider doing so.
20+
21+
2. Ensure that all recently closed PRs or issues are appropriately assigned to the milestone (`1.2.3`), if not already done.
22+
23+
3. Ensure all documentation is up to date
24+
25+
4. Create a new milestone for the next release, e.g., `1.2.4` or `1.3.0`, and move any remaining issues to it. This way, these tasks are carried over to the "next" release and can be easily located and prioritized.
26+
27+
5. Close the current milestone (`1.2.3`).
28+
29+
6. Finally, go to the GitHub releases page and [draft a new release](https://github.com/apple/swift-metrics/releases/new) with the details of the release version (`1.2.3` in this case) and any relevant release notes or changes. Be sure to include and create the new tag `1.2.3`.
30+

SECURITY.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@
22

33
## Supported Versions
44

5+
APNSwift will support the current release minus 1 with security updates
6+
57
| Version | Supported |
68
| ------- | ------------------ |
9+
| 5.x.x | :white_check_mark: |
710
| 4.x.x | :white_check_mark: |
8-
| 3.x.x | :white_check_mark: |
11+
| 3.x.x | |
912
| 2.x.x ||
1013
| 1.x.x ||
1114

SUPPORT.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
APNSwift will support the current release minus 1 with direct support. While the latest versions will get new features the N-1 release will get bug fixes and security fixes only.
2+
3+
To receive suport, please [open an issue](https://github.com/swift-server-community/APNSwift/issues), [create a discussion([https://github.com/swift-server-community/APNSwift/discussions), or join [this](https://join.slack.com/t/swift-open-source/shared_invite/zt-203tkfk9g-rCNUZgj5kKhz9QW6Z9Gwqw) slack and enter the channel #apns.
4+
Please refer to the [Contributing](CONTRIBUTING.md) section for more information on how to contribute to the project.
5+
6+
| Version | Supported |
7+
| ------- | ------------------ |
8+
| 5.x.x | :white_check_mark: |
9+
| 4.x.x | :white_check_mark: |
10+
| 3.x.x ||
11+
| 2.x.x ||
12+
| 1.x.x ||

0 commit comments

Comments
 (0)