[lldb] Reduce max-children-depth default for readability #10683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decrease `target.max-children-depth` from 6 to 4. Often the value of 6 produces too much output, particularly with Swift data where, unlike ObjC, classes are not treated as pointers and thus are traversed just like structs. For a hypothetical recursive struct with just two members/properties, a depth of 6 results in 63 (2^6-1) child values printed. In practice, data types commonly have more than two fields, and so hundred of child values can be printed. An output of only 63 would be closer to a best case scenario. This doesn't factor in lldb's data output syntax, which adds additional non-data lines to the output. When all children must be shown, frame variable and expression both support the -A (--show-all-children) flag. rdar://145327522
|
@swift-ci test |
|
See also llvm#139826 |
|
@swift-ci test |
adrian-prantl
approved these changes
May 14, 2025
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease
target.max-children-depthfrom 6 to 4. Often the value of 6 produces too muchoutput, particularly with Swift data where, unlike ObjC, classes are not treated as
pointers and thus are traversed just like structs.
For a hypothetical recursive struct with just two members/properties, a depth of 6
results in 63 (2^6-1) child values printed. In practice, data types commonly have more
than two fields, and so hundred of child values can be printed. An output of only 63
would be closer to a best case scenario. This doesn't factor in lldb's data output
syntax, which adds additional non-data lines to the output.
When all children must be shown,
frame variableandexpressionboth support the-A(
--show-all-children) flag.rdar://145327522