Skip to content

[windows][lldb] implement system logging on Windows #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: swift/release/6.2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/include/lldb/Host/Host.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ class Host {
/// Emit the given message to the operating system log.
static void SystemLog(lldb::Severity severity, llvm::StringRef message);

/// Emit the given message to the stdout or stderr depending on severity.
static void SystemLogFallback(lldb::Severity severity,
llvm::StringRef message);

/// Get the process ID for the calling process.
///
/// \return
Expand Down
12 changes: 6 additions & 6 deletions lldb/source/Host/common/Host.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,20 +110,20 @@ void Host::SystemLog(Severity severity, llvm::StringRef message) {
}
syslog(level, "%s", message.data());
}
#else
void Host::SystemLog(Severity severity, llvm::StringRef message) {
#endif
#endif

void Host::SystemLogFallback(Severity severity, llvm::StringRef message) {
switch (severity) {
case lldb::eSeverityInfo:
case lldb::eSeverityWarning:
llvm::outs() << message;
break;
return;
case lldb::eSeverityError:
llvm::errs() << message;
break;
return;
}
}
#endif
#endif

#if !defined(__APPLE__) && !defined(_WIN32)
static thread_result_t
Expand Down
61 changes: 61 additions & 0 deletions lldb/source/Host/windows/Host.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,13 @@
#include "lldb/Utility/StreamString.h"
#include "lldb/Utility/StructuredData.h"

#include "llvm/ADT/StringRef.h"
#include "llvm/Support/ConvertUTF.h"
#include "llvm/Support/ManagedStatic.h"

// Windows includes
#include <tlhelp32.h>
#include <windows.h>

using namespace lldb;
using namespace lldb_private;
Expand Down Expand Up @@ -302,3 +305,61 @@ Environment Host::GetEnvironment() {
}
return env;
}

class WindowsEventLog {
public:
WindowsEventLog() : handle(RegisterEventSource(nullptr, L"lldb")) {}

~WindowsEventLog() {
if (handle)
DeregisterEventSource(handle);
}

HANDLE GetHandle() const { return handle; }

private:
HANDLE handle;
};

static llvm::ManagedStatic<WindowsEventLog> event_log;

static LPCWSTR AnsiToUtf16(const std::string &ansi) {
if (ansi.empty())
return nullptr;
const int unicode_length =
MultiByteToWideChar(CP_ACP, 0, ansi.c_str(), -1, nullptr, 0);
WCHAR *unicode = new WCHAR[unicode_length];
MultiByteToWideChar(CP_ACP, 0, ansi.c_str(), -1, unicode, unicode_length);
return unicode;
}

void Host::SystemLog(Severity severity, llvm::StringRef message) {
HANDLE h = event_log->GetHandle();
if (!h) {
SystemLogFallback(severity, message);
return;
}

LPCWSTR wide_message = AnsiToUtf16(message.str());
if (!wide_message) {
SystemLogFallback(severity, message);
return;
}

WORD event_type;
switch (severity) {
case lldb::eSeverityWarning:
event_type = EVENTLOG_WARNING_TYPE;
break;
case lldb::eSeverityError:
event_type = EVENTLOG_ERROR_TYPE;
break;
case lldb::eSeverityInfo:
default:
event_type = EVENTLOG_INFORMATION_TYPE;
}

ReportEventW(h, event_type, 0, 0, nullptr, 1, 0, &wide_message, nullptr);

delete[] wide_message;
}