Skip to content

[Swift 6.2] Bring forward API notes improvements #11161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2025
Merged

[Swift 6.2] Bring forward API notes improvements #11161

merged 5 commits into from
Aug 14, 2025

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Aug 12, 2025 •
edited
Loading

@DougGregor
[API Notes] Attach API notes to forward declarations of tags
91c7fb3 
Forward declarations can still have useful API notes applied to them.

Fixes rdar://156288588.

(cherry picked from commit 81368e2)
@DougGregor
[API Notes] Ensure that redeclaration of tags doesn't duplicate attri…
fa872c4 
…butes

(cherry picked from commit 6e2683c)
@DougGregor
[API notes] Allow SwiftConformsTo on Typedefs
c0126a2 
SwiftConformsTo specifies an additional conformance that should be
applied on import. Allow this on typedefs, because those can be imported
as wrapper types.

Clang side of rdar://156290361

(cherry picked from commit 01b28c4)
@DougGregor
[API notes] Add a test for the use of SwiftConformsTo on a typedef
6e90682
@DougGregor
[APINotes] Add SwiftDestroyAs API note to map to the "destroy" function
40ae726 
Like retain/release for reference types, "destroy" lets us specify an
operation that is used to deinitialize an instance of a noncopyable type.
@DougGregor DougGregor requested a review from a team as a code owner August 12, 2025 18:18
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor mentioned this pull request Aug 12, 2025
Merged
@DougGregor
Copy link
Member Author

@swift-ci please test Windows

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test Windows

@cyndyishida cyndyishida merged commit 5cf5979 into swiftlang:swift/release/6.2 Aug 14, 2025
3 checks passed
@DougGregor DougGregor deleted the swift-6.2-apinotes-improvements branch August 14, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazax-hun Xazax-hun Xazax-hun approved these changes

@egorzhdan egorzhdan egorzhdan approved these changes

@cyndyishida cyndyishida cyndyishida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DougGregor @Xazax-hun @egorzhdan @cyndyishida