[AArch64] Add DEBUG_TYPE and wrap dump() in LLVM_DEBUG() #11868
Closed
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayAlias in AArch64InstrInfo.cpp calls dump() which is only enabled with NDEBUG or LLVM_ENABLE_DUMP.
Author
|
@swift-ci test |
|
Thanks, this snuck in on my cherry-pick, you can just remove it. Sorry about that |
|
Looked at this some more, the issue was a missed commit when I did the cherry pick from upstream LLVM to this branch. A proper fix is on this PR: #11870 |
jcohen-apple
requested changes
Nov 20, 2025
jcohen-apple
left a comment
jcohen-apple
left a comment
There was a problem hiding this comment.
See my comment, please merge my PR instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mayAlias in AArch64InstrInfo.cpp calls dump() which is only enabled with NDEBUG or LLVM_ENABLE_DUMP.
rdar://165133928