Skip to content

[cmake] Build with CMake on macOS #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[cmake] Build with CMake on macOS #1834

wants to merge 1 commit into from
+4 −1

Conversation

Steelskin
Copy link

  • Add CXX as a language. This is required to link in the standard library on macOS, which is used by dependencies.
  • Set up rpath for the macOS binary. This is necessary to produce a working binary post-installation.

@Steelskin
[cmake] Build with CMake on macOS
fdba32e 
* Add CXX as a language. This is required to link in the standard
  library on macOS, which is used by dependencies.
* Set up rpath for the macOS binary. This is necessary to produce a
  working binary post-installation.
@Steelskin Steelskin requested a review from ahoppen as a code owner November 19, 2024 00:48
@ahoppen
Copy link
Member

ahoppen commented Nov 19, 2024

Thanks for the PR. Out of curiosity: What’s your motivation to build SourceKit-LSP using CMake on macOS?

@ahoppen ahoppen mentioned this pull request Nov 19, 2024
Draft
@Steelskin
Copy link
Author

Thanks for the PR. Out of curiosity: What’s your motivation to build SourceKit-LSP using CMake on macOS?

We are building our own Swift toolchain and would like to share most of the build infrastructure with our existing Windows build, which uses CMake. Specifically, we would like to lower total install size so we are building with shared libraries.

@Steelskin
Copy link
Author

I am temporarily moving this PR to draft as I am changing the installation directories in other repositories. See this comment for details.

@Steelskin Steelskin marked this pull request as draft November 21, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham will be requested when the pull request is marked ready for review bnbarham is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight will be requested when the pull request is marked ready for review hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro will be requested when the pull request is marked ready for review rintaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steelskin @ahoppen