Add default implementations to LanguageService for methods that are not expected to be implemented by all language services
#2261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
ahoppen
commented
Aug 25, 2025
There was a problem hiding this comment.
These tests no longer worked since the DocumentationLanguageService now returns a requestNotImplemented for the completion request instead of returning empty results, which really makes more sense. These tests didn’t really provide much value, so I decided to remove them.
bnbarham
approved these changes
Aug 25, 2025
… not expected to be implemented by all language services With the introduction of secondary language services, we don’t expect every language service to implement every request anymore. To simplify the addition of language services like `DocumentationLanguageService` add default implementations for methods that satisfy the following criteria: - `SourceKitLSPServer` does not expect side effects to happen when they are called - The method can throw or there is a reasonable default value - It is reasonable to expect that not all language services need to implement it
ahoppen
force-pushed
the
split-language-services
branch
from
d22d31a to
4040a5e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of secondary language services, we don’t expect every language service to implement every request anymore. To simplify the addition of language services like
DocumentationLanguageServiceadd default implementations for methods that satisfy the following criteria:SourceKitLSPServerdoes not expect side effects to happen when they are called