Adjust test to reflect _Concurrency module hiding #2313
Conversation
beccadax
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci test |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Failure looks like we picked up swiftlang/swift-syntax#3156 without the matching swiftlang/swift#84553. |
|
@swift-ci test |
|
@swift-ci test Windows platform |
There was a problem hiding this comment.
Looking at this again, we need to allow both _Concurrency.swiftinterface and Swift.swiftinterface here because SourceKit-LSP tests need to also pass when running with the last released toolchain.
My suggestion would be to make assertSystemSwiftInterface take an array for swiftInterfaceFile and also add the following snippet so we remember that we can remove _Concurrency.swiftinterface in the future
#if compiler(>=6.4)
#warning("Remove _Concurrency.swifinterface and make assertSystemSwiftInterface take a single interface file name once we no longer need to support Swift 6.2 toolchains")
#endif
beccadax
force-pushed
the
common-concurrency
branch
from
d396b11 to
5ece925
Compare
|
@swift-ci test |
swiftlang/swift#84358 makes the `_Concurrency` module behave like a cross-import overlay of `Swift`. This changes downstream behavior in SourceKit-LSP. Update a test to reflect that change.
This is the line with the |
beccadax
force-pushed
the
common-concurrency
branch
from
5ece925 to
d579d5c
Compare
|
@swift-ci test |
|
@swift-ci test Windows platform |
swiftlang/swift#84358 makes the
_Concurrencymodule behave like a cross-import overlay ofSwift. This changes downstream behavior in SourceKit-LSP. Update a test to reflect that change.