Add case within XML Node's name setter for DTDKind (#5230) #5232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force set the name for XMLNodes when they're XMLDTDs as the regular _CFXMLNodeSetName function doesn't account for them anymore
|
@swift-ci test |
|
Looks reasonable - can we add a unit test too? |
|
There's this existing test that checks for this exact functionality: This issue only gets highlighted with the more recent libxml2 versions though, which the CI probably isn't on yet. Let me know if there's any other way to test this or other tests to add. |
|
Oh ok, that's fine then. Thanks. |
|
@swift-ci test |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Hi @parkera , looks like Windows CI is green now. Is that ok to merge? |
|
@parkera Friendly ping 🙂 We'd like to land this so we can pull it into our internal repo, is there anything else needed? |
parkera
approved these changes
Aug 8, 2025
|
Nope, just fell off my radar. Thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5230 by force setting the name for XMLNodes when they're XMLDTDs as the regular _CFXMLNodeSetName function doesn't account for them with future versions of libxml2