Repository navigation
Fix wrong order, or redundant try/await in generated code which caused warnings - #503
Merged
Merged
Conversation
Collaborator
|
Appreciate the attempt but if you ran |
ktoso
changed the title
Collaborator
|
I took a stab at fixing this up, thanks for picking up the topic! Next time please do run the tests locally and follow up to ensure they're passing 🙏 |
Contributor
Author
|
@ktoso Thanks for jumping in and fixing it — I appreciate you taking the time. |
Collaborator
|
No worries, thanks! Looking forward to more contributions :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
&
Fixes #470.
The JNI Swift generator emitted
await tryfor async throwing calls,which produces Swift compiler warnings. This change ensures
try awaitis emitted correctly.