[sidepelican]

Motivation

When shipping Swift libraries for Android applications, minimizing the binary size is highly desirable.
Currently, the runtime requirements for SwiftJava include several libraries that appear to be excessive.

This PR aims to reduce the number of dependencies to make the library more lightweight.

Changes

• Updated some implementations to depend only on FoundationEssentials where possible, avoiding the heavier full Foundation framework.
• Removed SwiftJavaConfigurationShared dependency, it was not being utilized within the target.

Results

By applying these changes, we have successfully reduced the number of required shared libraries (notably removing libdispatch, libswiftDispatch, libFoundation and libFoundationInternationalization).

• Original

root@14ca194994da:/swift-java# readelf -d .build/debug/libSwiftJava.so | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libswiftSwiftOnoneSupport.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswiftCore.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswift_Concurrency.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswift_StringProcessing.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswift_RegexParser.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswift_Builtin_float.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswift_math.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswiftAndroid.so]
 0x0000000000000001 (NEEDED)             Shared library: [libBlocksRuntime.so]
 0x0000000000000001 (NEEDED)             Shared library: [libdispatch.so]
 0x0000000000000001 (NEEDED)             Shared library: [libswiftDispatch.so]
 0x0000000000000001 (NEEDED)             Shared library: [libFoundation.so]
 0x0000000000000001 (NEEDED)             Shared library: [libFoundationEssentials.so]
 0x0000000000000001 (NEEDED)             Shared library: [libFoundationInternationalization.so]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so]
 0x0000000000000001 (NEEDED)             Shared library: [libc++_shared.so]
 0x0000000000000001 (NEEDED)             Shared library: [liblog.so]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so]

• This PR

root@14ca194994da:/swift-java# readelf -d .build/debug/libSwiftJava.so | grep NEEDED
0x0000000000000001 (NEEDED)             Shared library: [libswiftSwiftOnoneSupport.so]
0x0000000000000001 (NEEDED)             Shared library: [libswiftCore.so]
0x0000000000000001 (NEEDED)             Shared library: [libswift_Concurrency.so]
0x0000000000000001 (NEEDED)             Shared library: [libswift_StringProcessing.so]
0x0000000000000001 (NEEDED)             Shared library: [libswift_RegexParser.so]
0x0000000000000001 (NEEDED)             Shared library: [libswift_Builtin_float.so]
0x0000000000000001 (NEEDED)             Shared library: [libswift_math.so]
0x0000000000000001 (NEEDED)             Shared library: [libswiftAndroid.so]
0x0000000000000001 (NEEDED)             Shared library: [libFoundationEssentials.so]
0x0000000000000001 (NEEDED)             Shared library: [libm.so]
0x0000000000000001 (NEEDED)             Shared library: [libc++_shared.so]
0x0000000000000001 (NEEDED)             Shared library: [liblog.so]
0x0000000000000001 (NEEDED)             Shared library: [libdl.so]
0x0000000000000001 (NEEDED)             Shared library: [libc.so]

[ktoso]

Please run tests when you develop patches, this will crash with: SwiftJava/String+Extensions.swift:37: Fatal error: 'try!' expression unexpectedly raised an error: lookbehind is not currently supported

Happy to take the change but please make sure the tests are passing

[sidepelican]

I'm sorry for such a basic mistake.
I was only checking the swift-testing results and missed the failures in XCTest.

[sidepelican]

Fixed to not use lookbehind.
I noticed test_wrapJava_genericMethodTypeErasure_ofNullableOptional_staticMethods fails locally, but it also fails on main, so I'm assuming it's unrelated to these changes.

[ktoso]

Thanks! I'll check what's up with that other test

[ktoso]

Thank you, let's take this change :)