Skip to content

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 1, 2025

Some builtin attributes mistakingly accepted '(' on newline, while custom attribute didn't. For consistency, ignore '(' on next line.

@rintaro
Copy link
Member Author

rintaro commented Aug 1, 2025

swiftlang/swift#83497
@swift-ci Please test

@rintaro rintaro force-pushed the parse-attr-l-paren-newline branch from 1066b7f to b061f89 Compare August 4, 2025 15:48
@rintaro
Copy link
Member Author

rintaro commented Aug 4, 2025

swiftlang/swift#83497
@swift-ci Please test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Aug 4, 2025

swiftlang/swift#83497
@swift-ci Please test

Some builtin attributes mistakingly accepted '(' on newline, while
custom attribute didn't. For consistency, ignore '(' on next line.
@rintaro rintaro force-pushed the parse-attr-l-paren-newline branch from b061f89 to a666fd3 Compare August 20, 2025 18:32
@rintaro
Copy link
Member Author

rintaro commented Aug 20, 2025

swiftlang/swift#83497
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Aug 21, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

2 similar comments
@rintaro
Copy link
Member Author

rintaro commented Aug 21, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Aug 22, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@bnbarham
Copy link
Contributor

Re-running since this will end up failing with the foundation issue (I just merged a swift-corelibs-foundation change to fix that).

@bnbarham
Copy link
Contributor

swiftlang/swift#83497
@swift-ci Please test Windows

7 similar comments
@rintaro
Copy link
Member Author

rintaro commented Aug 22, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Aug 22, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Aug 23, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Aug 23, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@bnbarham
Copy link
Contributor

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Aug 25, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Aug 25, 2025

swiftlang/swift#83497
@swift-ci Please test Windows

@rintaro rintaro merged commit b4388e2 into swiftlang:main Aug 25, 2025
30 checks passed
@rintaro rintaro deleted the parse-attr-l-paren-newline branch August 25, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants