[windows] add PDB files to install target - #561
Open
charles-zablit wants to merge 1 commit into
Open
Conversation
Contributor
|
Does @compnerd's comment swiftlang/swift-toolchain-sqlite#41 (review) apply here too? |
Contributor
Author
It does but we can't apply it here because CMake does not support |
Member
|
I'm worried that this is just adding more debt - we should fix CMake first - there is no guarantee that the PDB path is what is computed here. |
charles-zablit
force-pushed
the
cz/windows/symbolfiles
branch
from
August 11, 2026 15:15
f3b233a to
6ec1eda
Compare
charles-zablit
marked this pull request as ready for review
August 11, 2026 15:15
compnerd
requested changes
Aug 11, 2026
compnerd
requested changes
Aug 11, 2026
compnerd
left a comment
compnerd
left a comment
Member
There was a problem hiding this comment.
Ah its internal, but its always set to true, so this is unnecessary.
compnerd
reviewed
Aug 11, 2026
charles-zablit
force-pushed
the
cz/windows/symbolfiles
branch
from
August 12, 2026 11:55
6ec1eda to
de50205
Compare
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Aug 14, 2026
charles-zablit
force-pushed
the
cz/windows/symbolfiles
branch
from
August 14, 2026 15:11
de50205 to
9898cca
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
We need the |
Member
|
What's the error? The optional is meant to avoid the errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of swiftlang/swift#88869.