Remove unnecessary type casting - #564
Conversation
51e1d58 to
2c9f1cb
Compare
|
@swift-ci please test |
|
Do we need to stage this in somehow? Unfortunately a lot of the dependents still have swift 6.2 CI jobs |
|
@owenv no, this should be backwards compatible. I'm not sure why the Linux build is impacted by this, this should only be touching the Windows paths. The |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
owenv
left a comment
There was a problem hiding this comment.
ok, I think this should be fine then so long as the tests pass
|
The linux failures are happening because we stopped producing toolchains for AL2 and the workflow YAML is out of date. UB9 is failing because the latest dev snapshot skipped it when publishing. Not caused by this change |
The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
Seems like an infrastructure issue on Linux @owenv @jakepetroules |
|
This job is using Swift 5.9 for some reason, I'm looking at why |
|
@swift-ci please test Linux platform |
The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast.