Skip to content

Remove unnecessary type casting - #564

Open
compnerd wants to merge 1 commit into
swiftlang:mainfrom
compnerd:typecast
Open

Remove unnecessary type casting#564
compnerd wants to merge 1 commit into
swiftlang:mainfrom
compnerd:typecast

Conversation

@compnerd

Copy link
Copy Markdown
Member

The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast.

@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test

@owenv

owenv commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Do we need to stage this in somehow? Unfortunately a lot of the dependents still have swift 6.2 CI jobs

@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@owenv no, this should be backwards compatible. I'm not sure why the Linux build is impacted by this, this should only be touching the Windows paths. The WinSDK+Overlay.swift is the backwards compatibility. Once we can move to 6.5, we should be able to drop that.

@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test

@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test Windows platform

@owenv owenv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think this should be fine then so long as the tests pass

@owenv

owenv commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The linux failures are happening because we stopped producing toolchains for AL2 and the workflow YAML is out of date. UB9 is failing because the latest dev snapshot skipped it when publishing. Not caused by this change

@compnerd compnerd moved this to In Progress in Swift on Windows Sep 2, 2026
The compiler now imports these as their canonical type, allowing us to
directly use without the explicit type cast.
@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test

@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test Windows platform

@compnerd

compnerd commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test Linux platform

1 similar comment
@compnerd

compnerd commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

@swift-ci please test Linux platform

@compnerd

compnerd commented Sep 3, 2026

Copy link
Copy Markdown
Member Author
23:46:57  /home/build-user/swift-argument-parser/Sources/ArgumentParser/Parsing/CommandParser.swift:305:11: error: consecutive declarations on a line must be separated by ';'
23:46:57    ) throws(CommandError) -> ParsableCommand {
23:46:57            ^
23:46:57            ;

Seems like an infrastructure issue on Linux @owenv @jakepetroules

@owenv

owenv commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This job is using Swift 5.9 for some reason, I'm looking at why

@compnerd

Copy link
Copy Markdown
Member Author

@swift-ci please test Linux platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants