PrintAsClang: Print #include to import headers used from @cdecl functions
#81481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci Please smoke test |
xymus
force-pushed
the
cdecl-includes
branch
2 times, most recently
from
12647d1 to
b5cbdec
Compare
|
@swift-ci Please smoke test |
Start printing `#include` for headers referenced from `@cdecl` function signatures. This adds on top of the existing tiered imports. We already print each module referenced from decls printed in the compatibility header. Previously we printed mostly `@import` with an option to fallback on a `#import`. This change adds a third fallback to `#include` when the module is referenced from a `@cdecl` function signature. The bridging header can also be imported in a similar way.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start printing
#includealternative to import modules and headers referenced from@cdeclfunction signatures. This adds on top of the existing tiered imports. We already print each module referenced from decls printed in the compatibility header with@importand an option to fallback on a#import. This change adds a third fallback to#includewhen the module is referenced from a@cdeclfunction signature. The bridging header is also be imported in a similar way with an#importwith a fallback on a#include.Followup to #80917 and #80744.