[CAS] Protect the CASOutputBackend from multi-threaded updates #82859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
changed the title
cachemeifyoucan
force-pushed
the
eng/PR-lock-output-cas-output-backend
branch
from
3c1490a to
c0c7c8a
Compare
cachemeifyoucan
changed the title
cachemeifyoucan
force-pushed
the
eng/PR-lock-output-cas-output-backend
branch
from
c0c7c8a to
286018d
Compare
|
@swift-ci please smoke test |
It is technically possible for different threads trying to write output files at the same time, e.g. multi-threaded WMO. It can cause a race condition to update the output status in the CAS output backend. Use a lock to protect the update and finalization of CAS entries.
cachemeifyoucan
force-pushed
the
eng/PR-lock-output-cas-output-backend
branch
from
286018d to
a816444
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is technically possible for different threads trying to write output files at the same time, e.g. multi-threaded WMO. It can cause a race condition to update the output status in the CAS output backend. Use a lock to protect the update and finalization of CAS entries.