[cxx-interop] Support calling functions in inline namespaces #83752
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
hborla,
xedin,
jckarter,
kavon,
beccadax,
ian-twilightcoder and
slavapestov
as code owners
|
@xedin could you take a look? This is just a first stab and I am not sure at all if this is the right approach here. |
The overload resolution generated a constraint that tried to bind outer.inline_inner to outer. This constraint failed. This PR attempts to recognize this scenario and make the constraint succeed, inserting a MetatypeConversionExpr that is later ignored by SILGen. rdar://158401346
Xazax-hun
force-pushed
the
fix-inline-namespaces
branch
from
ffcae60 to
4e69463
Compare
|
@swift-ci please smoke test |
Xazax-hun
commented
Aug 15, 2025
| @@ -22,5 +22,5 @@ import namespaces; | |||
|
|
|||
| // Swift's typechecker currently doesn't allow calling a function from inline namespace when it's referenced through the parent namespace. | |||
There was a problem hiding this comment.
TODO: remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overload resolution generated a constraint that tried to bind outer.inline_inner to outer. This constraint failed. This PR attempts to recognize this scenario and make the constraint succeed, inserting a MetatypeConversionExpr that is later ignored by SILGen.
rdar://158401346