Skip to content

Add support for Nushell env var settings #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MaxDesiatov
Copy link
Contributor

Currently, swiftly incorrectly generates Bash env var scripts when it is installed in Nushell.

Currently, swiftly incorrectly generates Bash env var scripts when it is installed in Nushell.
@cmcgee1024
Copy link
Member

Overall, this looks good.

question: where does the nu profile get modified so that when you start a new nu login shell you get the updated PATH and environment variables? For example, with bash/zsh it typically adds a source line in ~/.profile or ~/.zprofile that sources the env file in the swiftly home directory.

suggestion: The documentation and readme could be updated to announce this new feature of swiftly.

@MaxDesiatov MaxDesiatov marked this pull request as draft April 8, 2025 13:33
@cmcgee1024
Copy link
Member

@swift-ci test macOS

@cmcgee1024
Copy link
Member

@MaxDesiatov I was attempting to just make some suggested changes and ended up updating the branch. Apologies. I think that the merge conflicts are resolved, and things are passing the checks now.

@cmcgee1024
Copy link
Member

It looks like ubuntu doesn't yet come with nu shell, so there will likely need to be a release check similar to the other shell-based checks in .github/workflows/pull_request.yml, except it could manually curl the nu binary from a release on GitHub here: https://github.com/nushell/nushell/releases, install the binary, chsh to that shell and do the verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants