Allow disabling SwiftPM sandboxing #1386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
changed the title
|
@swift-ci please test |
award999
force-pushed
the
sandbox-rebased
branch
from
f633bcd to
6231c6b
Compare
|
@swift-ci please test |
award999
force-pushed
the
sandbox-rebased
branch
from
6231c6b to
e516f0b
Compare
|
@swift-ci please test |
award999
force-pushed
the
sandbox-rebased
branch
from
e516f0b to
182e817
Compare
|
@swift-ci please test |
award999
force-pushed
the
sandbox-rebased
branch
from
182e817 to
ae5b6ce
Compare
|
@swift-ci please test |
award999
force-pushed
the
sandbox-rebased
branch
from
ae5b6ce to
900366a
Compare
|
@swift-ci please test |
award999
force-pushed
the
sandbox-rebased
branch
3 times, most recently
from
e326b02 to
ff19a00
Compare
plemarquand
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Looks good to me. CI failure on 6.0 linux should hopefully be resolved by #1387
To get our tests to run in a sandbox, we need to disable sandboxing because you cannot create a new sandbox when you're already running under a sandbox - Add new `swift.disableSandbox` setting - Disable sandboxing for tasks and commands run by the extension - Disable hardware acceleration since ci.swift.org will run on x64 - Fix failing xcode watcher unit test - Increase some timeouts as build times seem slower on these nodes - Skip any LSP dependent tests for 6.0 or earlier. The LSP will only allow disabling sandboxing in 6.1+ - Disable debugging tests since need shareport permission
award999
force-pushed
the
sandbox-rebased
branch
from
21b4be7 to
9751d9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get our tests to run in a sandbox, we need to disable sandboxing because you cannot create a new sandbox when you're already running under a sandbox
swift.disableSandboxsetting