Adopt filePath in SourceLocation for swift-testing tests#2154
Merged
plemarquand merged 1 commit intoswiftlang:mainfrom Mar 13, 2026
Merged
Adopt filePath in SourceLocation for swift-testing tests#2154plemarquand merged 1 commit intoswiftlang:mainfrom
filePath in SourceLocation for swift-testing tests#2154plemarquand merged 1 commit intoswiftlang:mainfrom
Conversation
Nightly toolchains have now adopted `filePath` and removed `_filePath` from the `SourceLocation` object produced by `swift-testing`. Model our `SourceLocation` type as one that has either a `_filePath` or a `filePath` property, where one of them is always set. `filePath` was originally introduced in swiftlang/swift-testing#1334
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nightly toolchains have now adopted
filePathand removed_filePathfrom theSourceLocationobject produced byswift-testing.Model our
SourceLocationtype as one that has either a_filePathor afilePathproperty, where one of them is always set.filePathwas originally introduced in swiftlang/swift-testing#1334Tasks
Documentation has been updatedAdded an entry to CHANGELOG.md if applicable