Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing metadata #221

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: add missing metadata #221

merged 2 commits into from
Sep 20, 2024
+31 −0

Conversation

MakMuftic
Copy link
Contributor

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

wainola
wainola requested changes Sep 20, 2024
View reviewed changes
src/utils/domainMetadata.ts Outdated Show resolved Hide resolved
@MakMuftic MakMuftic merged commit 1636834 into main Sep 20, 2024
3 of 5 checks passed
@MakMuftic MakMuftic deleted the mmuftic/fix-missing-metadata-mainnet branch September 20, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainola wainola Awaiting requested review from wainola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MakMuftic @wainola