better fix for the freezing issue #153 #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freeze happened in case when conditions passed execution to the thread pool code. The code used to compute the number of threads to use expects a slice of at least twice the size of StripPadding, otherwise it can end up with no threads to use. In case it ended up with no threads, there was no one to signal the finished event. As one of the conditions for thread pool processing is to have more than 100k pixels to process, the necessary conditions couldn't be triggered for resolutions lower than 3226 px as described in the original fix, 3226 * 31 = 100006. With standard 4k resolution of 3840px the hang occurred in nTargetCY range of 27 to 31px.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze happened in case when conditions passed execution to the thread pool code. The code used to compute the number of threads to use expects a slice of at least twice the size of StripPadding, otherwise it can end up with no threads to use. In case it ended up with no threads, there was no one to signal the finished event.
As one of the conditions for thread pool processing is to have more than 100k pixels to process, the necessary conditions couldn't be triggered for resolutions lower than 3226 px as described in the original fix, 3226 * 31 = 100006. With standard 4k resolution of 3840px the hang occurred in nTargetCY range of 27 to 31px.