[bridge]: first batch of changes related to bridge#1453
Merged
Conversation
7832dbb to
7c9ae73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/bridge #1453 +/- ##
==================================================
+ Coverage 98.28% 98.34% +0.06%
==================================================
Files 161 170 +9
Lines 6763 7024 +261
Branches 143 143
==================================================
+ Hits 6647 6908 +261
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ad0ae2d to
7993e09
Compare
0ace720 to
6166b67
Compare
7993e09 to
2241833
Compare
This was referenced Jul 4, 2025
6166b67 to
e8aad53
Compare
problem: step one of bridge requires downloading and validating wrap requests from native network
solution: add `download_wrap_request_transactions` workflow to
* download transactions from network
* map each tranaction into a wrap request or wrap error
* populate a database with these requests and errors
at time of this commit, NEM downloads are fully supported
but workflow is generic enough to work with other networks
problem: download_wrap_request_transactions needs to work with Symbol too
solution: add Symbol adapters to `download_wrap_request_transactions`
generalize database to allow multiple wrap requests and/or errors per transaction
problem: need to calculate wrapped token : native token conversion rate solution: add (temporary) workflow to perform calculation and add missing functions
problem: need to be able to create transfer transactions for unwrap/redemption process solution: add create_transfer_transaction to nem and symbol NetworkFacade
problem: code assumes destination (wrapped) address is on ethereum network solution: relax assumption to allow nem <> symbol bridging
e8aad53 to
9b3f068
Compare
problem: need to track payout/issuance transactions solution: add payout_transaction table
…apped tokens
problem: wrapped tokens need to be sent to destination addresses
solution: add TransactionSender to simplify sending transactions to network(s)
update `calculate_conversions` workflow to send wrapped tokens
and set database request status to SENT
(this workflow is a WIP and likely to change)
1f249dc to
b196dbd
Compare
Wayonb
approved these changes
Jul 7, 2025
|
|
||
| TEST_RUNNER=$([ "$1" = "code-coverage" ] && echo "coverage run --append" || echo "python3") | ||
| ${TEST_RUNNER} -m pytest --asyncio-mode=auto -v | ||
| PYTHONPATH=.:./../lightapi/python ${TEST_RUNNER} -m pytest --asyncio-mode=auto -v |
Contributor
There was a problem hiding this comment.
Is this until lightapi is released?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.