[wallet/symbol/mobile] feat: add Bridge, Assets and Token Details screens#1988
[wallet/symbol/mobile] feat: add Bridge, Assets and Token Details screens#1988OlegMakarenko wants to merge 62 commits intodevfrom
Conversation
…t component for better presentation
…lteredListScreenTemplate
…up in Alert component
… to prevent text overlap
…tter customization
…log to visually separate multiple transactions
…template allowing pass additional custom modals
…l token amount from given fee tiers bundle
…ogress into separate component
…screen, update JS-Doc
…BridgeHistory, useBridgeNoPairsDialog, useBridgeTransaction, useEstimation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1988 +/- ##
==========================================
- Coverage 96.87% 96.85% -0.02%
==========================================
Files 261 257 -4
Lines 19119 19031 -88
Branches 215 215
==========================================
- Hits 18522 18433 -89
- Misses 591 592 +1
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
b0f3e4a to
5ec37aa
Compare
wallet/symbol/mobile/__fixtures__/local/TransactionFeeFixtureBuilder.js
Outdated
Show resolved
Hide resolved
wallet/symbol/mobile/src/screens/bridge/hooks/useBridgeTransaction.js
Outdated
Show resolved
Hide resolved
| /** @typedef {import('@/app/screens/bridge/types/Bridge').BridgeManager} BridgeManager */ | ||
| /** @typedef {import('@/app/screens/bridge/types/Bridge').BridgeRequest} BridgeRequest */ | ||
|
|
||
| const FETCH_INTERVAL = 10000; |
There was a problem hiding this comment.
Is this used for both the native and swap bridge addresses?
There was a problem hiding this comment.
Yes, they are combined into a single history.
There was a problem hiding this comment.
ok, was only concerned about Symbol/NEM where the status does not change every 10 seconds.
| iconName = iconNameMap.completed; | ||
| text = $t('s_bridge_history_status_completed'); | ||
| break; | ||
| case BridgePayoutStatus.FAILED: |
There was a problem hiding this comment.
Is a failed status retriable vs an error that is not?
There was a problem hiding this comment.
Just checked with CB - the status will not change for the current request. If payout is failed it will remain failed. Instead, at the same time a new request will be created and visible in the list.
There was a problem hiding this comment.
Yes, so are we showing the status of all the payout transactions? I am not sure how this looks in the UI.
My assumption is that the user only cares about the status of the last payout transaction.
…Manager into corresponding protocol projects
…reum gas fee placeholders
… state when bridges is empty array
Wayonb
left a comment
There was a problem hiding this comment.
Only a few comments but looks good👍🏾
Problem
Solution