SampleDocs add epochAdjustment#597
Open
kazumasamatsumoto wants to merge 9 commits intosymbol:mainfrom
kazumasamatsumoto:docs-repair
Open
SampleDocs add epochAdjustment#597kazumasamatsumoto wants to merge 9 commits intosymbol:mainfrom kazumasamatsumoto:docs-repair
kazumasamatsumoto wants to merge 9 commits intosymbol:mainfrom
kazumasamatsumoto:docs-repair
Conversation
segfaultxavi
requested changes
Mar 1, 2021
Collaborator
segfaultxavi
left a comment
segfaultxavi
left a comment
There was a problem hiding this comment.
Thank you very much for the patch!
However, this work was already started in pull request #551 and now the two PR clash.
Can you rebase your work on top of branch remove-hardcoded-values-from-examples so that only the new contributions are added? Fortunately our approaches are very similar :)
Also, please run npm run style:fix before submitting the PR. It was failing to build because of the style.
added 3 commits
March 10, 2021 23:33
Author
|
I did my best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the epoch adjustment section.