Resolve directories for copy from recipe in update case #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
force-pushed
the
fix-copy-from-recipe-aliases
branch
from
dfd3445 to
7392a69
Compare
maxhelias
approved these changes
Jan 23, 2023
|
This should add tests covering this behavior (in CopyFromRecipeConfiguratorTest) to prevent regressions. |
shyim
force-pushed
the
fix-copy-from-recipe-aliases
branch
3 times, most recently
from
42c2aa3 to
cdf1300
Compare
shyim
force-pushed
the
fix-copy-from-recipe-aliases
branch
from
cdf1300 to
8ba864e
Compare
|
the 7.4 fails because of packagist woofoo with composer 1 |
stof
reviewed
Apr 10, 2025
| $recipeUpdate, | ||
| [ | ||
| 'root/' => '', | ||
| 'symfony8config/' => '%CONFIG_DIR%/', |
There was a problem hiding this comment.
Having the recipe using symfony8config and mapping it to the usual config dir named config is not at all the use case that you want to solve (it is exactly the opposite use case). I suggest making the test cover the intended use case instead, as that's the use case for which we want to prevent regressions.
There was a problem hiding this comment.
I wanted to test, when the path is empty or you mapped to it %SOME-VAR%
I can remove it if you want. mapping config to %CONFIG_DIR% makes no difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update case of
CopyFromRecipeConfiguratordoes not respect the folders in the config.https://symfony.com/doc/current/setup/flex.html#customizing-flex-paths