Prevent vendor class name overlap #1681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1566
I've pasted this over the currently installed version in the project in which I had these issues, seems to work fine. Would be good if it could be re-checked and generally looked over, since I'm not 100% sure about it, but this is the place which causes the issue mentioned.
It should prevent situations where a known, working class name is skipped over and a vendor class is used instead, as there is no instance in which modifying vendor classes is required.
Actually this also seems to not work when it comes to classes with relations, so the target entity class (one we're adding relation to) may still be pulled from the vendor.