Skip to content

Conversation

Jean-Beru
Copy link

Add support of Symfony 8 and fixes typehint errors like

Compile Error: Declaration of Symfony\Bundle\MonologBundle\MonologBundle::build(Symfony\Component\DependencyInjection\ContainerBuilder $container) must be compatible with Symfony\Component\HttpKernel\Bundle\Bundle::build(Symfony\Component\DependencyInjection\ContainerBuilder $container): void

@Jean-Beru Jean-Beru changed the title Add support fo Symfony 8 Add support for Symfony 8 Aug 26, 2025
@@ -25,7 +25,7 @@
*/
class AddProcessorsPass implements CompilerPassInterface
{
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. We should think about releasing a new major.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or use that trait trick you created :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. We should think about releasing a new major.

Sure. If so, we could also think about removing support of sf < 6.4.

Or use that trait trick you created :)

What trait trick? I'm curious 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even the trait trick would be a BC break (but a conditional one, which is even worse to communicate)

However, given the time since the last major version, I think we could do one.

If so, we could also think about removing support of sf < 6.4.

this does not actually require a major version. We can do it in a minor version if we ensure we update the composer requirements properly (as composer will install compatible packages)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or use that trait trick you created :)

What trait trick? I'm curious 🙂

🙈 https://github.com/doctrine/dbal/blob/3.10.x/src/Tools/Console/Command/CommandCompatibility.php 🙈

I would prefer to go with a new major here in the case of our bundle.

@GromNaN GromNaN added this to the 4.0 milestone Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants