Add recipe for bref/symfony-bridge #1129

ker0x · 2021-04-27T12:16:54Z

Q	A
License	MIT

Following #1127, this is the first draft of the recipe.

Ping @t-richard, @mnapoli

ghost

Pull request does not pass validation.

bref/symfony-bridge/0.1/serverless.yaml

ghost

Pull request does not pass validation.

bref/symfony-bridge/0.1/serverless.yaml

ghost

Pull request passes validation.

ghost

Pull request passes validation.

bref/symfony-bridge/0.1/serverless.yaml

bref/symfony-bridge/0.1/post-install.txt

mnapoli · 2021-04-27T17:31:18Z

bref/symfony-bridge/0.1/manifest.json

@@ -0,0 +1,8 @@
+{
+    "copy-from-recipe": {
+        "serverless.yaml": "serverless.yaml"


Should be serverless.yml

Both are valid for Serverless and the choice to use .yaml may be because of the Validation applied to PRs here

YAML files suffix must be .yaml, not .yml

But the standard for Serverless Framework is indeed .yml. Maybe this could be used as a "workaround"

Suggested change

"serverless.yaml": "serverless.yaml"

"serverless.yml": "serverless.yaml"

BTW it's already accepted for docker-compose.yml if that may help and I think we are in the same situation because it's not Symfony config we are talking about but standard in a third-party tool

See for example : https://github.com/symfony/recipes/blob/master/doctrine/doctrine-bundle/1.6/manifest.json#L24

Yes, i used the .yaml extension to pass validation!

@t-richard wouldn't it be rather

Suggested change

"serverless.yaml": "serverless.yaml"

"serverless.yaml": "serverless.yml"

?

The other solution would be to store the serverless.yml into the package and use copy-from-package instead.

Yes it would be "serverless.yaml": "serverless.yml" 🤦

IMHO it makes more sense to have all here

bref/symfony-bridge/0.1/post-install.txt

bref/symfony-bridge/0.1/serverless.yaml

ghost

Pull request passes validation.

ghost

Pull request passes validation.

bref/symfony-bridge/0.1/serverless.yaml

mnapoli

All good to merge for me 👍

Thank you!

bref/symfony-bridge/0.1/serverless.yaml

OskarStark · 2021-04-29T09:23:00Z

bref/symfony-bridge/0.1/serverless.yaml

+        handler: public/index.php
+        timeout: 28 # in seconds (API Gateway has a timeout of 29 seconds)
+        layers:
+            - ${bref:layer.php-80-fpm}


Based on
https://github.com/brefphp/symfony-bridge/blob/6156395329df3bb34a9a17c5e440ca8ab76c173f/composer.json#L22

you can use the bridge with PHP 7.3, 7.4, but everything in the recipe contains php 8 🤔

Can't see the problem with that 🤔

IMHO We're just providing a decent default (7.3 is EOL and 8.0 is now supported by a fair amount of packages)

If they want, users can replace this line with a previous version this way and it will work

Suggested change

- ${bref:layer.php-80-fpm}

- ${bref:layer.php-74-fpm}

Co-authored-by: Oskar Stark <[email protected]>

ghost

Pull request passes validation.

Nyholm

Thank you

t-richard · 2021-04-29T09:43:27Z

Thank you @ker0x 👍

ghost suggested changes Apr 27, 2021

View reviewed changes

ker0x force-pushed the bref-symfony-bridge-recipe branch from edb11bd to e4e9abc Compare April 27, 2021 12:21

ghost suggested changes Apr 27, 2021

View reviewed changes

bref/symfony-bridge/0.1/serverless.yaml Outdated Show resolved Hide resolved

Add recipe for Bref Symfony Bridge

c108994

ker0x force-pushed the bref-symfony-bridge-recipe branch from e4e9abc to c108994 Compare April 27, 2021 12:24

ghost deployed to staging April 27, 2021 12:24 View deployment

ghost approved these changes Apr 27, 2021

View reviewed changes

ker0x changed the title ~~Add recipe for Bref Symfony Bridge~~ Add recipe for bref/symfony-bridge Apr 27, 2021

ghost deployed to staging April 27, 2021 12:36 View deployment

ghost approved these changes Apr 27, 2021

View reviewed changes

t-richard suggested changes Apr 27, 2021

View reviewed changes

bref/symfony-bridge/0.1/serverless.yaml Show resolved Hide resolved

bref/symfony-bridge/0.1/serverless.yaml Outdated Show resolved Hide resolved

bref/symfony-bridge/0.1/post-install.txt Show resolved Hide resolved

mnapoli reviewed Apr 27, 2021

View reviewed changes

Update serverless.yaml config

426f448

ghost deployed to staging April 28, 2021 08:55 View deployment

ghost approved these changes Apr 28, 2021

View reviewed changes

Changer serverless extension on copy

8259178

ghost deployed to staging April 28, 2021 12:32 View deployment

ghost approved these changes Apr 28, 2021

View reviewed changes

mnapoli reviewed Apr 29, 2021

View reviewed changes

bref/symfony-bridge/0.1/serverless.yaml Show resolved Hide resolved

mnapoli approved these changes Apr 29, 2021

View reviewed changes

OskarStark requested a review from Nyholm April 29, 2021 09:20

OskarStark reviewed Apr 29, 2021

View reviewed changes

bref/symfony-bridge/0.1/serverless.yaml Outdated Show resolved Hide resolved

OskarStark reviewed Apr 29, 2021

View reviewed changes

Update bref/symfony-bridge/0.1/serverless.yaml

2a6fd7f

Co-authored-by: Oskar Stark <[email protected]>

ghost deployed to staging April 29, 2021 09:34 View deployment

ghost approved these changes Apr 29, 2021

View reviewed changes

Nyholm approved these changes Apr 29, 2021

View reviewed changes

ghost merged commit 8e27732 into symfony:master Apr 29, 2021

ker0x deleted the bref-symfony-bridge-recipe branch April 29, 2021 09:54

ker0x mentioned this pull request Apr 29, 2021

Bref Symfony Bridge recipe #1127

Closed

mnapoli mentioned this pull request Jan 16, 2022

serverless.yml file is deleted when package is uninstalled brefphp/symfony-bridge#55

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for bref/symfony-bridge #1129

Add recipe for bref/symfony-bridge #1129

ker0x commented Apr 27, 2021

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

mnapoli Apr 27, 2021

t-richard Apr 27, 2021 •

edited

Loading

t-richard Apr 27, 2021

ker0x Apr 28, 2021

t-richard Apr 28, 2021

ghost left a comment

ghost left a comment

mnapoli left a comment

OskarStark Apr 29, 2021

t-richard Apr 29, 2021

ghost left a comment

Nyholm left a comment

t-richard commented Apr 29, 2021

	"serverless.yaml": "serverless.yaml"
	"serverless.yml": "serverless.yaml"

	"serverless.yaml": "serverless.yaml"
	"serverless.yaml": "serverless.yml"

Add recipe for bref/symfony-bridge #1129

Add recipe for bref/symfony-bridge #1129

Conversation

ker0x commented Apr 27, 2021

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

mnapoli Apr 27, 2021

Choose a reason for hiding this comment

t-richard Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

t-richard Apr 27, 2021

Choose a reason for hiding this comment

ker0x Apr 28, 2021

Choose a reason for hiding this comment

t-richard Apr 28, 2021

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

mnapoli left a comment

Choose a reason for hiding this comment

OskarStark Apr 29, 2021

Choose a reason for hiding this comment

t-richard Apr 29, 2021

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Nyholm left a comment

Choose a reason for hiding this comment

t-richard commented Apr 29, 2021

t-richard Apr 27, 2021 •

edited

Loading