-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mercuryseries/inertia-bundle recipe #1517
Add mercuryseries/inertia-bundle recipe #1517
Conversation
mercuryseries
commented
May 29, 2023
Q | A |
---|---|
License | MIT |
Packagist | https://packagist.org/packages/mercuryseries/inertia-bundle |
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
# defaults: | ||
# csrf: | ||
# create: true | ||
# require: ['POST', 'PUT', 'PATCH', 'DELETE'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only need one of these - iirc, type: annotations
will work for both.
However, if I'm understanding this correctly, then what you are REALLY doing is just adding the defaults: csrf:
part to the user's existing route import, right? In that case, my previous comment was wrong... and you may indeed need to use add-lines
to add this to the existing config/routes.yaml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @weaverryan for the feedback. Really appreciated!
I finally decided to handle this on the bundle side. So I think it can be merged now.
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access