Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mercuryseries/inertia-bundle recipe #1517

Conversation

mercuryseries
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:02
@github-actions
Copy link

github-actions bot commented May 29, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1517/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1517/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'mercuryseries/inertia-bundle:^0.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled May 29, 2023 21:07

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:07
auto-merge was automatically disabled May 29, 2023 21:12

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:12
auto-merge was automatically disabled May 29, 2023 21:21

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:22
auto-merge was automatically disabled May 29, 2023 21:23

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:24
auto-merge was automatically disabled May 29, 2023 21:32

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:32
auto-merge was automatically disabled May 29, 2023 21:38

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:38
auto-merge was automatically disabled May 29, 2023 21:50

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:51
auto-merge was automatically disabled May 29, 2023 21:53

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 29, 2023 21:53
auto-merge was automatically disabled May 30, 2023 20:57

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 20:58
auto-merge was automatically disabled May 30, 2023 21:04

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 21:04
auto-merge was automatically disabled May 30, 2023 21:06

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 21:06
auto-merge was automatically disabled May 30, 2023 21:15

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 21:15
auto-merge was automatically disabled May 30, 2023 21:20

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 21:21
auto-merge was automatically disabled May 30, 2023 21:23

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 21:24
auto-merge was automatically disabled May 30, 2023 21:38

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 30, 2023 21:38
# defaults:
# csrf:
# create: true
# require: ['POST', 'PUT', 'PATCH', 'DELETE']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need one of these - iirc, type: annotations will work for both.

However, if I'm understanding this correctly, then what you are REALLY doing is just adding the defaults: csrf: part to the user's existing route import, right? In that case, my previous comment was wrong... and you may indeed need to use add-lines to add this to the existing config/routes.yaml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weaverryan for the feedback. Really appreciated!
I finally decided to handle this on the bundle side. So I think it can be merged now.

auto-merge was automatically disabled June 19, 2023 06:54

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) June 19, 2023 06:54
auto-merge was automatically disabled June 19, 2023 07:05

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) June 19, 2023 07:06
@symfony-recipes-bot symfony-recipes-bot merged commit 89b05a0 into symfony:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants