Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use token #1576

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Use token #1576

merged 3 commits into from
Dec 15, 2023

Conversation

OskarStark
Copy link
Contributor

Copy link

github-actions bot commented Dec 15, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1576/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1576/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'datana-gmbh/iusta-api:^2.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

datana-gmbh/iusta-api

1.0 vs 2.0
diff --git a/datana-gmbh/iusta-api/1.0/config/packages/datana_iusta_api.yaml b/datana-gmbh/iusta-api/2.0/config/packages/datana_iusta_api.yaml
index 9b9a8116..12ddcf90 100644
--- a/datana-gmbh/iusta-api/1.0/config/packages/datana_iusta_api.yaml
+++ b/datana-gmbh/iusta-api/2.0/config/packages/datana_iusta_api.yaml
@@ -5,8 +5,7 @@ services:
     Datana\Iusta\Api\IustaClient:
         arguments:
             - '%env(IUSTA_API_BASE_URI)%'
-            - '%env(IUSTA_API_USERNAME)%'
-            - '%env(IUSTA_API_PASSWORD)%'
+            - '%env(IUSTA_API_TOKEN)%'
 
     Datana\Iusta\Api\AktenApi: null
     Datana\Iusta\Api\AktenApiInterface: '@Datana\Iusta\Api\AktenApi'
diff --git a/datana-gmbh/iusta-api/1.0/manifest.json b/datana-gmbh/iusta-api/2.0/manifest.json
index 6c3da778..dadc6509 100644
--- a/datana-gmbh/iusta-api/1.0/manifest.json
+++ b/datana-gmbh/iusta-api/2.0/manifest.json
@@ -4,7 +4,6 @@
     },
     "env": {
         "IUSTA_API_BASE_URI": "",
-        "IUSTA_API_USERNAME": "",
-        "IUSTA_API_PASSWORD": ""
+        "IUSTA_API_TOKEN": ""
     }
 }

@OskarStark
Copy link
Contributor Author

Updated to 2.0, thanks @Nyholm

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@symfony-recipes-bot symfony-recipes-bot merged commit 3298326 into symfony:main Dec 15, 2023
1 of 2 checks passed
@OskarStark OskarStark deleted the adjust branch December 15, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants