Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Sylius Stack Flex recipes #1686

Merged

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Oct 8, 2024

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 8, 2024 13:30
Copy link

github-actions bot commented Oct 8, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1686/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1686/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'sylius/admin-ui:^0.4' 'sylius/bootstrap-admin-ui:^0.4' 'sylius/resource-bundle:^1.12' 'sylius/twig-extra:^0.4' 'sylius/twig-hooks:^0.4' 'sylius/ui-translations:^0.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

sylius/resource-bundle

1.6 vs 1.9
diff --git a/sylius/resource-bundle/1.6/config/packages/sylius_resource.yaml b/sylius/resource-bundle/1.9/config/packages/sylius_resource.yaml
index df27a441..6b42a484 100644
--- a/sylius/resource-bundle/1.6/config/packages/sylius_resource.yaml
+++ b/sylius/resource-bundle/1.9/config/packages/sylius_resource.yaml
@@ -3,6 +3,11 @@ sylius_resource:
     # Override default settings
     #settings:
 
+    # Configure the mapping for your resources
+    mapping:
+        paths:
+            - '%kernel.project_dir%/src/Entity'
+
     # Configure your resources
     resources:
         #app.book:
diff --git a/sylius/resource-bundle/1.9/config/routes/sylius_resource.yaml b/sylius/resource-bundle/1.9/config/routes/sylius_resource.yaml
new file mode 100644
index 00000000..0c8ade2c
--- /dev/null
+++ b/sylius/resource-bundle/1.9/config/routes/sylius_resource.yaml
@@ -0,0 +1,7 @@
+sylius_crud_routes:
+    resource: 'sylius.routing.loader.crud_routes_attributes'
+    type: service
+
+sylius_routes:
+    resource: 'sylius.routing.loader.routes_attributes'
+    type: service
1.9 vs 1.12
diff --git a/sylius/resource-bundle/1.9/manifest.json b/sylius/resource-bundle/1.12/manifest.json
index a26e89c8..a38eab72 100644
--- a/sylius/resource-bundle/1.9/manifest.json
+++ b/sylius/resource-bundle/1.12/manifest.json
@@ -6,6 +6,7 @@
         "Sylius\\Bundle\\ResourceBundle\\SyliusResourceBundle": ["all"]
     },
     "copy-from-recipe": {
-        "config/": "%CONFIG_DIR%/"
+        "config/": "%CONFIG_DIR%/",
+        "src/": "%SRC_DIR%/"
     }
 }
diff --git a/sylius/resource-bundle/1.12/src/Entity/.gitignore b/sylius/resource-bundle/1.12/src/Entity/.gitignore
new file mode 100644
index 00000000..e69de29b

auto-merge was automatically disabled October 8, 2024 13:34

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 8, 2024 13:35
auto-merge was automatically disabled October 8, 2024 13:36

Head branch was pushed to by a user without write access

@loic425 loic425 force-pushed the init-sylius-stack-flex-recipes branch from a90f231 to ed3bf19 Compare October 8, 2024 13:36
@loic425 loic425 marked this pull request as draft October 8, 2024 13:36
@loic425 loic425 force-pushed the init-sylius-stack-flex-recipes branch from ed3bf19 to 0985291 Compare October 8, 2024 13:37
@loic425 loic425 marked this pull request as ready for review October 8, 2024 13:38
@loic425 loic425 closed this Oct 8, 2024
@loic425 loic425 reopened this Oct 8, 2024
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 8, 2024 13:39
@loic425
Copy link
Contributor Author

loic425 commented Oct 8, 2024

Sylius Grid bundle needs to be fixed to work without doctrine/orm, but it seems ok.
I've checked locally, installing symfony skeleton, add doctrine/orm ^2.18 first and then these packages' installation was ok.

image

auto-merge was automatically disabled October 8, 2024 14:08

Head branch was pushed to by a user without write access

@loic425 loic425 force-pushed the init-sylius-stack-flex-recipes branch from 0985291 to 01f3107 Compare October 8, 2024 14:08
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 8, 2024 14:09
@symfony-recipes-bot symfony-recipes-bot merged commit 295c0b7 into symfony:main Oct 8, 2024
1 of 2 checks passed
@loic425 loic425 deleted the init-sylius-stack-flex-recipes branch October 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants