mv spatie/symfony-ignition-bundle/0.0/config/packages{,/dev}/ignition.yaml

[n0099]

fix There is no extension able to load the configuration for "ignition" (in "config/packages/ignition.yaml"). Looked for namespace "ignition", found "framework", "doctrine", "twig". when under environments other than dev

Q	A
License	MIT
Packagist	https://packagist.org/packages/spatie/symfony-ignition-bundle

[github-actions]

Thanks for the PR 😍

How to test these changes in your application

1. Define the SYMFONY_ENDPOINT environment variable:

   # On Unix-like (BSD, Linux and macOS)
   export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1689/index.json
   # On Windows
   SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1689/index.json

2. Install the package(s) related to this recipe:

   composer req 'symfony/flex:^1.16'
   composer req 'spatie/symfony-ignition-bundle:^0.0'

3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

   # On Unix-like (BSD, Linux and macOS)
   unset SYMFONY_ENDPOINT
   # On Windows
   SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

[diimpp]

Hi @n0099, thank you for your contribution!

I would suggest an alternative approach to wrap config with when@dev like so (instead of moving config to config/packages/dev):

when@dev:
    ignition:
        application_path: '%kernel.project_dir%'
        dark_mode: false
        should_display_exception: '%kernel.debug%'

This approach is available since symfony 5.3 and spatie/symfony-ignition-bundle minimal requirement is 5.4, so we should be safe to use it.

And it's currently preferred way to do it, as shown in example https://github.com/symfony/demo/blob/f39ffa0c5983cd50f73a8d6ef1026422ca4ec355/config/packages/monolog.yaml#L5-L24

I've opened PR with same fix at spatie/symfony-ignition-bundle#29