[Routing] add mapped route parameters and aliases#20812

Closed

eltharin wants to merge 8 commits intosymfony:7.3from

eltharin:mappedrouteparameters

Contributor

eltharin commented Mar 24, 2025 •

edited

Loading

Add documentation for Mapped Route Parameters and Aliased Mapped route parameters :
symfony/symfony#59904

carsonbot added the Status: Needs Review label

carsonbot added this to the 7.3 milestone


          add mapped route parameters and aliases

e37a9dc

eltharin force-pushed the mappedrouteparameters branch from 5025b48 to e37a9dc Compare

March 24, 2025 17:30

OskarStark added the Routing label

carsonbot changed the title ~~add mapped route parameters and aliases~~ [Routing] add mapped route parameters and aliases

OskarStark reviewed

View reviewed changes

doctrine.rst Outdated Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

doctrine.rst Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

doctrine.rst Outdated Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

doctrine.rst Outdated Show resolved Hide resolved


          corrections

36cdca5

MrYamous reviewed

View reviewed changes

doctrine.rst Outdated Show resolved Hide resolved


          Update doctrine.rst

a60587c

Co-authored-by: Matthieu Lempereur <matt.lempereur@gmail.com>

MrYamous reviewed

View reviewed changes

doctrine.rst Outdated Show resolved Hide resolved

MrYamous reviewed

View reviewed changes

doctrine.rst Outdated Show resolved Hide resolved

eltharin added 5 commits

March 25, 2025 06:54


          remove traillingslash and backticks

ab4ac88


          MrYamous changes

c0ead98


          was-were

23a1f0d


          update from comments

286ba1b


          remove the

63db3a4

eltharin requested a review from OskarStark

April 18, 2025 11:04

nicolas-grekas mentioned this pull request

[Routing] Tell about {foo:bar} mapping syntax #20956

Merged

javiereguiluz added a commit that referenced this pull request


          minor #20956 [Routing] Tell about {foo:bar} mapping syntax (nicolas…

2d7393a

…-grekas)

This PR was merged into the 7.2 branch.

Discussion
----------

[Routing] Tell about `{foo:bar}` mapping syntax

Fix #20806
Fix #19846
Fix #19848
Replaces #19869
Replaces #20812

Commits
-------

e591c59 [Routing] Tell about {foo:bar} mapping syntax

Member

javiereguiluz commented May 20, 2025

@eltharin thanks a lot for this contribution. Although your proposal is technically correct, sadly we have to close it without merging because we came up with an alternative PR (#20956) that also fixed other minor issues in routing docs. Sorry!

javiereguiluz closed this

Contributor Author

eltharin commented May 20, 2025

@javiereguiluz no problem, what about #20820 ? Should I continue it?

eltharin deleted the mappedrouteparameters branch

June 17, 2025 08:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Routing Status: Needs Review