Clarify that APP_SECRET is still required in remember_me docs#21985
Open
lacatoire wants to merge 2 commits intosymfony:7.3from
Open
Clarify that APP_SECRET is still required in remember_me docs#21985lacatoire wants to merge 2 commits intosymfony:7.3from
lacatoire wants to merge 2 commits intosymfony:7.3from
Conversation
Collaborator
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The versionadded note for Symfony 7.2 in
remember_me.rststated that "The secret option is no longer required", which was misleading — it implied thatAPP_SECRETitself was no longer needed. This led to production failures when no secret was configured.The reworded note clarifies that:
secretoption now defaults to%kernel.secret%and doesn't need to be set explicitlyAPP_SECRETenvironment variable must still be defined, especially in productionFixes #21372