[CI] Use git diff instead of git status #2687
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check failed here because file changed .. but with no content change.
Do you have a link to a failed job? I would like to understand what you call "with no real content change", thanks 🙏🏻 |
|
Mmmh, why not, in #2663 it happens because lines 4 to 29 have CRLF instead of LF chars we expect (or vice-versa). Let's merge it, but I will open a new PR to enforce LF chars for text files |
Kocal
approved these changes
Apr 11, 2025
carsonbot
added
Status: Reviewed
|
Thanks Simon. |
Kocal
added a commit
that referenced
this pull request
Apr 13, 2025
This PR was merged into the 2.x branch. Discussion ---------- Add .editorconfig, enforce LF line-ending style | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #2687 Commits ------- aafa87b Add .editorconfig, enforce LF line-ending style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI often fails on the "check dist files" script because some dist file changed .. with no real content change
This PR replace the
git status --porcelainwith agit diff --quietto ignore this situation.