Skip to content

[TwigComponent] Fix loadTemplate deprecation for Twig >= 3.21 #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

[TwigComponent] Fix loadTemplate deprecation for Twig >= 3.21 #2713

wants to merge 2 commits into from

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented May 6, 2025

@Kocal
Copy link
Member

Kocal commented May 6, 2025

Are failing checks for LiveComponent https://github.com/symfony/ux/actions/runs/14850493570/job/41693042531?pr=2713 are related to your changes?

@smnandre
Copy link
Member Author

smnandre commented May 6, 2025

They are, but because they are hardcoded values.. that is dependending on internal code in TwigComponent.

Let's try to fix this later this week and we will merge this MR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Needs to be reviewed TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComponentNode uses $this->loadTemplate which is deprecated in Twig 3.20.0
3 participants
@smnandre @Kocal @carsonbot